Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6988 bestimmte css definitionen wieder von rem auf px umstellen #7070

Closed
wants to merge 5 commits into from
Closed

6988 bestimmte css definitionen wieder von rem auf px umstellen #7070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d0b66e
refactor: replace rem() for some special css definitions to px
deleonio Oct 29, 2024
4a0511b
Merge branch 'develop' into 6988-bestimmte-css-definitionen-wieder-vo…
deleonio Nov 6, 2024
1349372
Merge branch 'develop' into 6988-bestimmte-css-definitionen-wieder-vo…
deleonio Nov 6, 2024
033315b
chore: release 2.2.0
publicuibot[bot] Nov 14, 2024
9a0ea7b
Merge branch 'release/2' into 6988-bestimmte-css-definitionen-wieder-…
deleonio Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lerna.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@
"packages/tools/visual-tests"
],
"useNx": true,
"version": "2.2.0-alpha.0"
"version": "2.2.0"
}
2 changes: 1 addition & 1 deletion packages/adapters/angular/v15/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/angular-v15",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/angular/v16/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/angular-v16",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/angular/v17/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/angular-v17",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/angular/v18/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/angular-v18",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/hydrate/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/hydrate",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/preact/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/preact",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/react-standalone/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/react-standalone",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/react",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/solid/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/solid",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/adapters/vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/vue",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/components",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/@shared/_kol-table-stateless-mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,14 +121,14 @@
align-items: center;
justify-content: center;
background-color: rgb(255, 255, 255);
border-width: rem(2);
border-width: 2px;
line-height: 1.5;
transition: all 0.5s ease 0s;
}

input[type='radio'] {
display: flex;
border-width: rem(2);
border-width: 2px;
border-radius: 100%;
height: 1.5em;
min-height: 1.5em;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/drawer/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@

&__content {
position: relative;
padding: rem(16);
padding: 16px;
}
}
}
2 changes: 1 addition & 1 deletion packages/components/src/components/input-checkbox/common.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@

input {
border-style: solid;
border-width: rem(2);
border-width: 2px;
line-height: 1.5;
}

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/input-radio/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

@layer kol-component {
:host {
--border-width: #{rem(2)};
--border-width: 2px;
--input-size: 1.5em;
font-size: rem(16);
}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/input-range/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
background-color: #000;
height: rem(20);
width: rem(20);
border-radius: rem(20);
border-radius: 20px;
cursor: pointer;
-webkit-appearance: none;
}
Expand All @@ -53,7 +53,7 @@
background-color: #000;
height: rem(20);
width: rem(20);
border-radius: rem(20);
border-radius: 20px;
cursor: pointer;
-moz-appearance: none;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/components/src/components/input.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,12 @@

/* needed hack for vertical alignment */
input[type='file'] {
padding: calc((var(--a11y-min-size) - rem(16)) / 10) 0.5em;
padding: calc((var(--a11y-min-size) - 16px) / 10) 0.5em;
}

/* needed hack for vertical alignment */
select[multiple] option {
padding: calc((var(--a11y-min-size) - rem(16)) / 2) 0.5em;
padding: calc((var(--a11y-min-size) - 16px) / 2) 0.5em;
}

.input {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/components/spin/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

.spin {
display: block;
padding: rem(2);
padding: 2px;
position: relative;
}
}
2 changes: 1 addition & 1 deletion packages/designer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/designer",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"license": "EUPL-1.2",
"homepage": "https://public-ui.github.io",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@public-ui/sample-react",
"version": "2.2.0-alpha.0",
"version": "2.2.0",
"description": "This app contains samples for the KoliBri/Public UI",
"license": "EUPL-1.2",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/samples/react/src/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ hr {
background-color: black;
display: flex;
flex-direction: column;
padding: rem(8);
padding: 8px;
}

@media (min-width: 1024px) {
Expand Down
2 changes: 1 addition & 1 deletion packages/themes/bmf/src/components/abbr.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@
}

abbr:focus {
border-radius: rem(5);
border-radius: 5px;
}
}
2 changes: 1 addition & 1 deletion packages/themes/bmf/src/components/accordion.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

border-radius: var(--border-radius);
min-height: rem(24);
padding: rem(10) rem(8);
padding: 10px 8px;

@include kol-typography-accordion;
gap: rem(8);
Expand Down
8 changes: 4 additions & 4 deletions packages/themes/bmf/src/components/badge.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
}

:host > span {
border-radius: rem(5);
border-radius: 5px;
display: inline-flex;
font-style: normal;

.kol-span-wc {
padding: rem(4) rem(12);
padding: 4px 12px;
}

> .kol-span-wc {
Expand All @@ -35,7 +35,7 @@
align-items: center;

.kol-span-wc {
padding: rem(4) rem(8) rem(4) rem(12);
padding: 4px 8px 4px 12px;
}
}

Expand Down Expand Up @@ -72,7 +72,7 @@
outline-color: var(--color-ocean);
outline-offset: rem(2);
outline-style: solid;
outline-width: rem(3);
outline-width: 3px;
transition: outline-offset 0.2s linear;
}
}
Expand Down
6 changes: 3 additions & 3 deletions packages/themes/bmf/src/components/button.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
outline-color: var(--color-ocean);
outline-offset: rem(2);
outline-style: solid;
outline-width: rem(3);
outline-width: 3px;
transition: outline-offset 0.2s linear;
}

Expand All @@ -18,10 +18,10 @@
font-weight: 700;
border-radius: var(--a11y-min-size);
border-style: solid;
border-width: rem(2);
border-width: 2px;
min-height: var(--a11y-min-size);
min-width: var(--a11y-min-size);
padding: rem(8) rem(14);
padding: 8px 14px;
text-align: center;
transition-duration: 0.5s;
transition-property: background-color, color, border-color;
Expand Down
10 changes: 5 additions & 5 deletions packages/themes/bmf/src/components/card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,25 +12,25 @@
height: 100%;
background-color: white;
grid-template-rows: min-content 2fr min-content;
box-shadow: 0 0 rem(4) var(--color-grey);
border-radius: rem(4);
box-shadow: 0 0 4px var(--color-grey);
border-radius: 4px;
}

:host .kol-heading-wc {
line-height: 1.75;
}

:host div.header {
padding: rem(16) rem(16) rem(8) rem(16);
padding: 16px 16px 8px 16px;
}

:host div.content {
padding: rem(8) rem(16) rem(16);
padding: 8px 16px 16px;
overflow: hidden;
}

:host div.footer {
padding: rem(8) rem(16);
padding: 8px 16px;
}

:host > div > div.content + div.footer {
Expand Down
4 changes: 2 additions & 2 deletions packages/themes/bmf/src/components/combobox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ $visible-options: 5;

&__listbox {
border-style: solid;
border-width: rem(1);
border-width: 1px;
border-radius: var(--border-radius);
border-color: var(--color-grey);
overflow-y: auto;
Expand All @@ -66,7 +66,7 @@ $visible-options: 5;
display: flex;
align-items: center;
min-height: $option-height;
padding: rem(10) rem(12);
padding: 10px 12px;
border-radius: 0.25em;
color: var(--color-black);

Expand Down
2 changes: 1 addition & 1 deletion packages/themes/bmf/src/components/details.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
border: none;

&:hover {
box-shadow: 0 rem(3) var(--color-ocean);
box-shadow: 0 3px var(--color-ocean);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion packages/themes/bmf/src/components/drawer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

@layer kol-theme-component {
:host .drawer__wrapper {
box-shadow: 0 0 rem(4) var(--color-grey);
box-shadow: 0 0 4px var(--color-grey);
}
}
6 changes: 3 additions & 3 deletions packages/themes/bmf/src/components/input-checkbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,9 @@
order: 1;
width: 100%;
border-color: var(--color-grey);
border-width: rem(2);
border-width: 2px;
border-style: solid;
border-radius: rem(5);
border-radius: 5px;
line-height: 1;
font-size: rem(16);

Expand Down Expand Up @@ -343,7 +343,7 @@
min-height: rem(34);
border: rem(3) solid var(--color-ocean);
background-clip: content-box; // emulate outline with offset
padding: rem(2);
padding: 2px;
}
}

Expand Down
4 changes: 2 additions & 2 deletions packages/themes/bmf/src/components/input-radio.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,9 @@
cursor: pointer;

border-color: var(--color-grey);
border-width: rem(2);
border-width: 2px;
border-style: solid;
border-radius: rem(5);
border-radius: 5px;
font-size: rem(16);

&:hover {
Expand Down
Loading
Loading