Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abbr: Replace tooltip #7006

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Abbr: Replace tooltip #7006

wants to merge 8 commits into from
+37 −253

Conversation

sdvg
Copy link
Member

@sdvg sdvg commented Nov 4, 2024 •
edited by github-actions bot
Loading

The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer:

  • Maturation completed and documented
  • Meaningful pull request title for the release notes
  • Pull request is linked to an issue
  • All changes relate to the issue
  • No commented out code in the final commit
  • Tests to protect this code implemented (if applicable)
  • Manual test performed successfully (if applicable)
  • Documentation or migration has been updated (if applicable)

@sdvg sdvg linked an issue Nov 4, 2024 that may be closed by this pull request
abbr - Langform in Klammern hinter Abkürzung #6627
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 4, 2024 •
edited
Loading

Netlify Draft Deployment
URL: https://673860b51cddd51fd8be6700--kolibri-public-ui.netlify.app
Logs: https://app.netlify.com/sites/kolibri-public-ui/deploys/673860b51cddd51fd8be6700

@sdvg sdvg marked this pull request as ready for review November 4, 2024 18:18
@deleonio deleonio added the v3 Here are issues that need to be resolved for version 3. label Nov 6, 2024
deleonio
deleonio requested changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@deleonio deleonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sdvg Mir fehlt leider noch das für Abbr übliche Styling.

Kannst Du das bitte "wiederherstellen"?

image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deleonio deleonio deleonio requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
v3 Here are issues that need to be resolved for version 3.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

abbr - Langform in Klammern hinter Abkürzung
2 participants
@sdvg @deleonio