Added ShortKey Prop to Elements with AccessKey
#6957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
Netlify Draft Deployment |
deleonio
requested changes
Oct 25, 2024
AlexanderSchmidtCE
changed the title
deleonio
requested changes
Nov 12, 2024
There was a problem hiding this comment.
@AlexanderSchmidtCE Ich habe noch 20/147 unter Beobachtung. Aber sonst sieht das schon gut aus.
packages/components/src/components/span/InternalUnderlinedAccessKey.tsx
Outdated
Show resolved
Hide resolved
This was referenced Nov 13, 2024
deleonio
requested changes
Nov 13, 2024
deleonio
previously approved these changes
Nov 14, 2024
|
@AlexanderSchmidtCE bitte dringen CI fixen. Schau mal, ob die Tests lokal auch laufen. |
|
Wir haben jetzt die Funktion |
sdvg
requested changes
Nov 14, 2024
There was a problem hiding this comment.
Siehe #6957 (comment)
Checks sollten natürlich noch durchlauf, dann passt für mich alles 🎉
…n-bei-tooltips' into 6251--feature-shortkey-ermglichen-bei-tooltips # Conflicts: # packages/components/src/components/span/test/__snapshots__/snapshot.spec.tsx.snap Refs: #6251
…s://github.com/public-ui/kolibri into 6251--feature-shortkey-ermglichen-bei-tooltips
deleonio
approved these changes
Nov 14, 2024
sdvg
approved these changes
Nov 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The A11y and PO reviews will only take place after all other DoD steps have been completed by the Developer: