-
Notifications
You must be signed in to change notification settings - Fork 33
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Abbr: Replace tooltip for full form with a simple description in pare…
…ntheses. Refs: #6627
- Loading branch information
Showing
17 changed files
with
42 additions
and
177 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Breaking Changes for version 3 | ||
|
||
## Introduction | ||
|
||
New major versions of KoliBri are developed with the goal of simplifying maintenance and support and promoting further development. | ||
|
||
For more information, see the [KoliBri Maintenance and Support Strategy](https://github.com/public-ui/kolibri/blob/develop/MIGRATION.md). | ||
|
||
## Components | ||
|
||
### kol-abbr | ||
|
||
- Visually, the tooltip has been replaced by a simple label shown in parentheses after the abbreviation. | ||
- The property `_tooltipAlign` has been removed. |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,8 +5,4 @@ | |
:host { | ||
font-size: rem(16); | ||
} | ||
|
||
:host > abbr { | ||
cursor: help; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,21 @@ | ||
import { mixMembers } from 'stencil-awesome-test'; | ||
|
||
import type { AbbrProps } from '../../../schema'; | ||
import { KolTooltipWcTag } from '../../../core/component-names'; | ||
|
||
export const getAbbrHtml = (props: AbbrProps): string => { | ||
props = mixMembers( | ||
{ | ||
_label: '', // ⚠ required | ||
_tooltipAlign: 'top', | ||
}, | ||
props, | ||
); | ||
return ` | ||
<kol-abbr class="kol-abbr"> | ||
<mock:shadow-root> | ||
<abbr aria-labelledby="nonce" role="definition" tabindex="0" ${typeof props._label === 'string' ? ` title="${props._label}"` : ''}> | ||
<span> | ||
<slot /> | ||
</span> | ||
<abbr> | ||
<slot></slot> | ||
</abbr> | ||
<${KolTooltipWcTag} _align=${props._tooltipAlign} _id="nonce" _label=${props._label}></${KolTooltipWcTag}> | ||
${props._label ? ` (${props._label})` : ''} | ||
</mock:shadow-root> | ||
</kol-abbr>`; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.