DE: DB HAFAS: update ver & ext #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traines-source
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
For reference, the diffs of some example old vs new responses – as far as I can see, no notable changes apart from some additional fields (and hafas-client seems to work seamlessly with the new version):
journey.diff.txt
board.diff.txt
But there also don't seem to be any benefits regarding missing prices or server errors...
Apart from that I don't really see what to review here :D
|
It seems that |
|
Oh good catch 🙈 But at least hafas-client already supports |
vkrause
approved these changes
Dec 10, 2024
derf
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
verof1.78is reported by the server as thehciVersion.remotely related discussions: