ÖBB HAFAS: update "ver" to "1.45" #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derf
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
ÖBB HAFAS versions sure are interesting.
I vaguely recall maybe encountering occasional issues on dbf.finalrewind.org and travelynx.de with 1.41; at least I did not go back to that version when moving from my own database to this repository and there were at least some backends where I needed to bump the version. Though, at least in theory, I should already have opened PRs for all of those. Right now I'm using 1.57 and haven't seen any errors in prod.
I can't reproduce any of the errors mentioned in the referenced issue. From cursory tests 1.41, 1.45, 1.57 und 1.80 appear identical – at least to my API consumers. So I'm fine with keeping it safe and limiting the bump to 1.45 for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to fix public-transport/hafas-client#233.