Update minter and collection ownership #603
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's confusion over collection owners and minters right now. To clarify it, I propose we move to this solution:
So now collection administration is passed through from the minter. We don't have to check
creator
inCollectionInfo
anymore.So now:
TODO:
admin
inConfigExtension
withcw-ownable
.admin
tocw-ownable
.UpdateCollectionInfo {}
and others can be added to the minter as wellNOTE:
Here's how to do extend cw721 execute messages the "proper" way: https://github.com/public-awesome/core/pull/16/files#diff-b5b5b8636528b3755dac1ab0e2d1c015b3fbcf730232bdc68e6fd81352a3a3e1R61