-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SG-997 Add IBC denoms to open edition #596
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #596 +/- ##
==========================================
+ Coverage 59.52% 60.40% +0.88%
==========================================
Files 83 85 +2
Lines 4212 4521 +309
==========================================
+ Hits 2507 2731 +224
- Misses 1705 1790 +85
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides some minor refactoring.
I wanted to start using Typescript for e2e tests but since this already has Rust-based tests, it's fine that it's continued. I understand that its beyond the scope of this PR to do that.
Cosm-Orc Gas Usage
Raw Report for 9ada038
|
@yubrew We can update to use the Fair Burn contract now since its on mainnet yeah? |
pub airdrop_mint_price_amount: Option<Uint128>, | ||
} | ||
|
||
pub const DEFAULT_CUSTOM_PARAMS: OpenEditionMinterCustomParams = OpenEditionMinterCustomParams { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can use the Default
trait here
config.fee_percent is 50%, this contract needs a different percent. |
ibc denoms for open edition minter (
frenz
)I ran e2e tests locally and they passed