customizable behaviour for activity rendering in the view #148
+79
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… partial is missing. this is in line with the docs that read 'If a view file does not exist, then p_a falls back to the old behaviour and tries to translate the activity :key using I18n#translate method (see the section below)'. However - instead of doing it by default it only exibits this behaviour when :fallback => :text is provided. This way the other tests that rely on ActionView::MissingTemplate be raised still pass. README updated to match new implementation.
…nstead of raising an exception. README updated.
|
Hi Chris, this sounds like a very good feature to have! The updated Readme is especially appreciated :) Could you also document it in YARD above the method? |
…arameter. Closed some dangling open brackets in the README.
|
Cool. I've updated the YARD docs in: shorrockin@2e2f4eb |
|
Much obliged 👍 |
pokonski
added a commit
that referenced
this pull request
May 21, 2014
customizable behaviour for activity rendering in the view
pokonski
added a commit
that referenced
this pull request
May 21, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a project where I dynamically instrument the models for an extremely large project in order to generate activity on all models - which are then surfaced in an admin interface to provide an audit log of sorts.
For this reason it's a little bit of a headache to proactively define the views for every action. These two commits add two features that make this a bit easier for my use-case.
Not sure if either of these are enough value to pull them into the official version - but they're super useful to me, so I thought I'd throw them your way. tests, and README changes included. Cheers.