Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6520 Implementation for chunking in WebRTC Plugin #6521

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#6520 Implementation for chunking in WebRTC Plugin #6521

wants to merge 1 commit into from

Conversation

haouarihk
Copy link

@haouarihk haouarihk commented Oct 22, 2024 •
edited by pubkey
Loading

This PR contains:

  • Added chunking to messages sent using simple-peer to handle large data.

Related: #6520

@haouarihk
Copy link
Author

if there are any changes you want me to make, please let me know

@pubkey
Copy link
Owner

pubkey commented Nov 3, 2024

Hi @haouarihk . Please also add some tests for this.

@pubkey
Copy link
Owner

pubkey commented Nov 7, 2024

@haouarihk Your fix looks good. Can you add some tests?

@haouarihk
Copy link
Author

As I mentioned in the issue.
Its not possible. Because it needs browser tests.
This issue only appear in browser environment

@pubkey
Copy link
Owner

pubkey commented Nov 17, 2024 •
edited
Loading

@haouarihk you are right, sorry for that. So the first step would be to add some browser based tests.

@pubkey pubkey mentioned this pull request Nov 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs test case 🔎
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@haouarihk @pubkey