Apply suggestions from code review - pass 3

Co-authored-by: Andreas Möller <[email protected]>
ptomulik · Jun 4, 2020 · 2516d89 · 2516d89
1 parent ac672fb
commit 2516d89
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/tests/unit/Framework/Constraint/UnaryTestCase.php b/tests/unit/Framework/Constraint/UnaryTestCase.php
@@ -112,7 +112,7 @@ public function testNonRestrictedConstructParameterIsTreatedAsIsEqual(): void
 
     public function providerUnaryTruthTable()
     {
-        return \array_map(function (bool $input) {
+        return \array_map(function (bool $input): array {
             return [$input, $this->evaluateExpectedResult($input)];
         }, [false, true]);
     }
@@ -145,13 +145,15 @@ public function testEvaluateReturnsNullOnSuccessAndThrowsExceptionOnFailure(bool
 
         if ($expected) {
             $this->assertNull($constraint->evaluate(null));
-        } else {
-            $expectedString = $operand->toString();
-            $message        = "Failed asserting that 'the following expression is not true' " . $expectedString;
-            $this->expectException(ExpectationFailedException::class);
-            $this->expectExceptionMessage($message);
-            $constraint->evaluate('the following expression is true');
+
+            return;
         }
+
+        $expectedString = $operand->toString();
+        $message        = "Failed asserting that 'the following expression is not true' " . $expectedString;
+        $this->expectException(ExpectationFailedException::class);
+        $this->expectExceptionMessage($message);
+        $constraint->evaluate('the following expression is true');
     }
 
     /**