Skip to content

Commit

Permalink
Comment out rest of the fontdemo (bazelbuild#364)
Browse files Browse the repository at this point in the history
This  test is already commented the target is marked as local
  • Loading branch information
gkdn authored and ptmphuong committed Dec 9, 2022
1 parent 46b8268 commit 8aaee26
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions closure/testing/test/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -111,27 +111,27 @@ closure_js_test(
],
)

genrule(
name = "fontdemo",
srcs = [
"screenshot.js",
"fontdemo.html",
],
outs = ["fontdemo-generated.png"],
cmd = "$(location //third_party/phantomjs) $(SRCS) $@",
# TODO(user): Remove local = 1 when ariya/phantomjs#13876 is fixed.
local = 1,
tags = ["requires-network"],
tools = ["//third_party/phantomjs"],
)

# This test shows how to write tests to verify rendered output from phantomjs.
# However, you shouln't do this because the output image depends on a lot of
# external factors like operating system, GPU, ..., and therefore has a
# very hight chance of being flaky.
# https://github.com/bazelbuild/rules_closure/issues/247
# https://github.com/bazelbuild/rules_closure/pull/186#issuecomment-279115018
#
# genrule(
# name = "fontdemo",
# srcs = [
# "screenshot.js",
# "fontdemo.html",
# ],
# outs = ["fontdemo-generated.png"],
# cmd = "$(location //third_party/phantomjs) $(SRCS) $@",
# # TODO(user): Remove local = 1 when ariya/phantomjs#13876 is fixed.
# local = 1,
# tags = ["requires-network"],
# tools = ["//third_party/phantomjs"],
# )
#
# files_equal_test(
# name = "noto_fonts_render_as_expected",
# actual = "fontdemo-generated.png",
Expand Down

0 comments on commit 8aaee26

Please sign in to comment.