Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DYNAREC_RV64] Added support for xtheadba #970

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

ksco
Copy link
Collaborator

@ksco ksco commented Sep 12, 2023

No description provided.

@ksco
Copy link
Collaborator Author

ksco commented Sep 12, 2023

Dont forget to squash ;-)

@ksco
Copy link
Collaborator Author

ksco commented Sep 12, 2023

                if (rv64_zba) {
                    SHxADD(x3, x1, 2+rex.w, wback);
                } else if (rv64_xtheadba) {
                    TH_ADDSL(x3, wback, x1, 2+rex.w);
                } else {
                    SLLI(x1, x1, 2+rex.w);
                    ADD(x3, wback, x1);
                }

This pattern is common, maybe a macro?

@ptitSeb
Copy link
Owner

ptitSeb commented Sep 12, 2023

                if (rv64_zba) {
                    SHxADD(x3, x1, 2+rex.w, wback);
                } else if (rv64_xtheadba) {
                    TH_ADDSL(x3, wback, x1, 2+rex.w);
                } else {
                    SLLI(x1, x1, 2+rex.w);
                    ADD(x3, wback, x1);
                }

This pattern is common, maybe a macro?

Yeah, if you can do a macro for this one; like SLxADD(r1, r2, imm3)?

@ksco
Copy link
Collaborator Author

ksco commented Sep 12, 2023

Done, but why CI is failing, it passed on my machine.

@ptitSeb
Copy link
Owner

ptitSeb commented Sep 12, 2023

Done, but why CI is failing, it passed on my machine.

I don't know, but that seems like a leggit error.

@ksco
Copy link
Collaborator Author

ksco commented Sep 12, 2023

Done, but why CI is failing, it passed on my machine.

I don't know, but that seems like a leggit error.

Yeah it's because qemu and my machine have different extensions, fixing... We should run the tests multi times with different extension sets...

@ptitSeb ptitSeb merged commit 71ad38d into ptitSeb:main Sep 12, 2023
24 checks passed
@ksco ksco deleted the xtheadba branch September 12, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants