Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WRAPPERS] Add a isSimpleWrapper function for RV64 #1185

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

rajdakin
Copy link
Collaborator

@rajdakin rajdakin commented Jan 4, 2024

This PR adds support for the isSimpleWrapper function on RISC-V 64. It also adds a default function returning 0 if the architecture is unsupported (i.e. not ARM or RISC-V).
There is also minor fixes in the script (the "free letters" comment does not contain x and X, an error message was incorrect, and a type hint was invalid for mypy).
The first commit contains the entire change, the second contains only a version bump.

Copy link
Collaborator

@ksco ksco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We’re filtering all the sign-extended ones for RV64? This makes the simple functions set much smaller than AArch64, but it’s a start to enable this feature I think.

@ksco
Copy link
Collaborator

ksco commented Jan 5, 2024

A more complicated proposal: make isSimpleWrapper return a uint64_t and every 2-bits indicates the width of the current sign-extended parameter/return value:

00 -> not sign-extended
01 -> signed char
10 -> short
11 -> int

@ptitSeb
Copy link
Owner

ptitSeb commented Jan 5, 2024

A more complicated proposal: make isSimpleWrapper return a uint64_t and every 2-bits indicates the width of the current sign-extended parameter/return value:

00 -> not sign-extended
01 -> signed char
10 -> short
11 -> int

Return value is already used to check float / double stuff iirc.

@ptitSeb ptitSeb merged commit e4821aa into ptitSeb:main Jan 5, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants