Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unable to build since https://github.com/ptitSeb/box64/commit/48b881f4912bc795e0467e334e359e9876f73c4f #342

Closed
theofficialgman opened this issue Jul 3, 2022 · 11 comments

Comments

@theofficialgman
Copy link
Contributor

during building:

/home/gman/box64/src/libtools/threads.c: In function ‘my_pthread_cond_clockwait’:
/home/gman/box64/src/libtools/threads.c:678:16: warning: implicit declaration of function ‘pthread_cond_clockwait’; did you mean ‘my_pthread_cond_clockwait’? [-Wimplicit-function-declaration]
  678 |         return pthread_cond_clockwait(cond, getAlignedMutex((pthread_mutex_t*)mutex), __clock_id, __abstime);
      |                ^~~~~~~~~~~~~~~~~~~~~~
      |                my_pthread_cond_clockwait

and failure during linking

CMakeFiles/box64.dir/src/libtools/threads.c.o: In function `my_pthread_cond_clockwait':
/home/gman/box64/src/libtools/threads.c:678: undefined reference to `pthread_cond_clockwait'
collect2: error: ld returned 1 exit status
@ptitSeb
Copy link
Owner

ptitSeb commented Jul 3, 2022

On what are you building?

@theofficialgman
Copy link
Contributor Author

theofficialgman commented Jul 3, 2022

switch and nvidia jetson (arm64 ubuntu bionic) with gcc 11

@theofficialgman
Copy link
Contributor Author

install-fail-Box64.log

thats my full log if you find it helpful

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 3, 2022

I guess this phtread function is to recent for your system
I'll make the call optionnal, and return -1 if the function is not there.

@theofficialgman
Copy link
Contributor Author

that is correct. it was added in glibc 2.30 https://abi-laboratory.pro/index.php?view=changelog&l=glibc&v=2.30

@theofficialgman
Copy link
Contributor Author

theofficialgman commented Jul 3, 2022

it might be worthwhile to add CI for building on ubuntu bionic, or debian buster (or both) since these are the most used platforms for box64 instead of using 20.04 for everything

ubuntu-18.04 is available through github actions which you can use to do this

@PeterStrick
Copy link

it might be worthwhile to add CI for building on ubuntu bionic, or debian buster (or both) since these are the most used platforms for box64 instead of using 20.04 for everything

ubuntu-18.04 is available through github actions which you can use to do this

Github Actions are actually used to build box64 on every commit
Just that the GitHub Action uses ubuntu-latest

@theofficialgman
Copy link
Contributor Author

I am aware. which is why I am suggesting to use ubuntu-18.04 (instead of ubuntu-latest which currently is focal and will eventually be jammy)

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 3, 2022

Yeah, I'll try to setup one of the build on an older OS version.

@ptitSeb
Copy link
Owner

ptitSeb commented Jul 4, 2022

If you have suggestion on how to modify the current github workflow to add some ubuntu 18 testing (for TegraX1 for example). I would like to avoid doing the tests twice, but just selecting to OS depending on the config

@theofficialgman
Copy link
Contributor Author

closing as the commits related prior solve compilation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants