Update from terraform master #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
depends_on = ["aws_internet_gateway.gw"] is the correct syntax
* Remove enable_deletion_protection from testAccDataSourceAWSELBConfigBasic * Replace unnecessary errwrap.Wrapf with fmt.Errorf * Reduce flattenAwsELbResource to ec2conn and elbconn instead of meta * Properly name TestAccDataSourceAWSELB_basic resources * Use t.Name() for description and TestName tags
…th new d/aws_elasticache_replication_group
…certs Add sweeper for IAM Server Certificates
test/aws_config_delivery_channel: Add missing dependencies
New Data Source: aws_elb
* r/aws_elasticache_security_group: add import support * r/aws_elasticache_security_group: #2277 review updates * Use d.Id() instead of d.Get("name") on read, which allows using schema.ImportStatePassthrough * d.Set("security_group_names") on read * Set AWS_DEFAULT_REGION to us-east-1 on import testing
Corrected depends_on entry for EIP
Added missing WARN debug lines when reading a non-existing resource
documentation: remove antislashes in page titles
Update cognito_user_pool.markdown
* Query elb API for load balancer arn causing delete conflict - For IAM server certificate. * Use regex for lb name. * Edits for #2533
* WIP * Add enabled * Use cwl policy * Reflect reviews
* Add force_destroy field to aws_athena_database. Fixes #2362. * Remove unnecessary import. * Code review feedback
Bump aws-sdk-go to v.1.12.44
* New Resource: aws_media_store_container * Reflect reviews * remove policy
* add AUTH, at-rest and in-transit encryption to Elasticache replication groups * add _enabled to transit/at_rest encyrption parameters * added one more _enabled * move validateAwsElastiCacheReplicationGroupAuthToken to aws/validators.go, as well as tests * set auth_token to nil during Reads * update Replication Group encryption acceptance tests to use config functions instead of vars * Fix whitespacing (tabs -> spaces)
* r/aws_dynamodb_table: Ensure ttl is properly read * r/aws_dynamodb_table: #2452 review updates * Add timeToLiveOutput.TimeToLiveDescription nil check * Simplify logic to d.Set ttl
docs/elasticache_replication_group: Add missing fields
* WIP * Add test, docs * Reflect reviews * Modify error handling
Makefile: Add sweep target
Bump aws-sdk-go to v.1.12.45
Add more example and missing field
* New Resource: service_discovery_private_dns_namespace * Reflect reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.