Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BF: close existing EyeLinkCustomDisplay during runSetupProcedure #12

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

mh105
Copy link
Contributor

@mh105 mh105 commented Aug 17, 2024

We need to close any existing EyeLinkCoreGraphicsIOHubPsychopy during runSetupProcedure so that multiple calibration routines can be called within the same experiment. However, EyeLinkCoreGraphicsIOHubPsychopy must be defined for the end of an experiment in order for receiveDataFile() that makes a get_input_keys() call to work.

@mh105 mh105 changed the title BF: close EyeLinkCustomDisplay after runSetupProcedure BF: close existing EyeLinkCustomDisplay during runSetupProcedure Sep 6, 2024
@mh105
Copy link
Contributor Author

mh105 commented Sep 6, 2024

@TEParsons This PR is ready to merge! Will also be good to release a new version on PyPI - this allows users to do multiple calibration procedures within the same experiment, which is often necessary if there is a break period in-between blocks of trials.

@mh105
Copy link
Contributor Author

mh105 commented Oct 29, 2024

@TEParsons Hey Todd, just pinging again to see if this could get merged. Thank you!!

@TEParsons
Copy link
Collaborator

Hey, sorry this one kept slipping through my to do list! I just want to check with @mdcutone as I know he was looking into similar stuff around ioHub closing its graphics after calibration, to make sure it doesn't conflict with anything he's doing in PsychoPy.

@TEParsons TEParsons merged commit e17379a into psychopy:main Oct 30, 2024
3 checks passed
@mh105
Copy link
Contributor Author

mh105 commented Oct 30, 2024

@TEParsons Thanks! Yeah we can't close the graphics after calibration because it is needed at the end of an experiment for receiving the data from EyeLink PC to the task PC. So this BF just checks whether pylink.eyelink.customGraphics already exists at the beginning of calibration, if so then we close it and start a new one.

Would you mind trigger the publishing workflow as well and bump up the version number? That way folks can download this using the Plug-in & Package manager GUI within PsychoPy to get this fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants