Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a function for getting the name of a request #320

Closed
wants to merge 1 commit into from

Conversation

psychon
Copy link
Owner

@psychon psychon commented Apr 2, 2020

Signed-off-by: Uli Schlachter [email protected]


This is how far I got before noticing that #314 does not really work. Dunno if this should be merged or not.

  • TODO: It just occurred to me that this should use the generated constants instead of having just the plain number

@eduardosm
Copy link
Collaborator

whoops, I mistakenly checked the TODO checkbox (and then unchecked it again), just in case you get some notification about me modifying this PR

@psychon
Copy link
Owner Author

psychon commented Apr 19, 2020

Nope, no notifications. :-)

@eduardosm
Copy link
Collaborator

Can this be closed?

@psychon
Copy link
Owner Author

psychon commented May 20, 2020

Dunno. I still feel like this could be useful, but so far have not come across a case where I would be able to use this information. If #314 is not possible... well, I guess then this should be closed. Do you agree that #314 is not possible and that the addition in this PR is not useful?

@eduardosm
Copy link
Collaborator

If #314 is not possible, I cannot think of any other use of this right now. Anyways, this is right now written for the old python generator, so if someday we want this, it would need to be done from scratch.

@eduardosm eduardosm closed this May 20, 2020
@psychon psychon deleted the request_names branch May 20, 2020 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants