Extend custom properties to quantitative properties #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Main changes: - step away from RDFS like pseudo-definition of properties -- this only looked good superficially - introduce `has_property` property to hold quantitative and qualitative properties via the established `meta_type` approach. - `Property` now uses `is_about` for specifying the purpose/topic of a property - `Property` now uses `type` to indicate the type of the value (pretty much for casting use cases, because `value` itself has a range of `string`) - `Property` now has `is_defined_by` to indicate the proper term that defined the value (string) or takes its place - `QuantitativeProperty` is a `Property` with a unit - `Property.value` is no longer multivalued -- no known use case. Given that a type declaration is needed already and casting must be performed by consumers, an array-like encoding of some kind (JSON?) could be chosen and indicated by a user without being enforced by the schema. As a demo (for now) we also introduce initial structures to associate an Activity (like a study) with an entity (like a resource), and agents (like study participants) with an activity: - `was_generated_by` - `was_associated_with` - `qualified_association` They follow the standard patterns already established for other relationships. Closes #110
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes:
has_propertyproperty to hold quantitative and qualitative properties via the establishedmeta_typeapproach.Propertynow usesis_aboutfor specifying the purpose/topic of a propertyPropertynow usestypeto indicate the type of the value (pretty much for casting use cases, becausevalueitself has a range ofstring)Propertynow hasis_defined_byto indicate the proper term that defined the value (string) or takes its placeQuantitativePropertyis aPropertywith a unitProperty.valueis no longer multivalued -- no known use case. Given that a type declaration is needed already and casting must be performed by consumers, an array-like encoding of some kind (JSON?) could be chosen and indicated by a user without being enforced by the schema.As a demo (for now) we also introduce initial structures to associate an Activity (like a study) with an entity (like a resource), and agents (like study participants) with an activity:
was_generated_bywas_associated_withqualified_associationThey follow the standard patterns already established for other relationships.
Closes #110