Fix dockerfile executable path, add git to container #354
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path seems out of date. I'm not knowledgeable in setuptools (or python at all for that matter, I had already tried using
did
a while ago but I had enough of it after 5 minutes due to the usual virtualenv mess) so maybe it's supposed to actually install in/usr/bin
but isn't.I've also added
git
to make the extension work within docker.safe.directory
set to*
allows git to get the logs in directories in which the user is not an owner (likely the case for docker).Side note: I also changed the docker run command I personally use. I don't think
--privileged
is actually needed. I haven't changed the docs in this PR, I don't know if there are use cases where it does make sense. For reference, this is what I use: I also added a new volume for the repository I want to track using git.Suggestion: may be a good idea to use a custom entrypoint script that can parse
$1
values likebash
/sh
and execute the commands accordingly, useful when debugging the container itself. Personally I just switched back and forth fromENTRYPOINT
toCMD
so I could test it out doingdid bash
.