Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerfile executable path, add git to container #354

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

thehowl
Copy link
Contributor

@thehowl thehowl commented Jan 29, 2024

The path seems out of date. I'm not knowledgeable in setuptools (or python at all for that matter, I had already tried using did a while ago but I had enough of it after 5 minutes due to the usual virtualenv mess) so maybe it's supposed to actually install in /usr/bin but isn't.

I've also added git to make the extension work within docker. safe.directory set to * allows git to get the logs in directories in which the user is not an owner (likely the case for docker).

Side note: I also changed the docker run command I personally use. I don't think --privileged is actually needed. I haven't changed the docs in this PR, I don't know if there are use cases where it does make sense. For reference, this is what I use: I also added a new volume for the repository I want to track using git.

docker run --rm -it -v /home/howl/.config/did:/did.conf -v /home/howl/oc/gno:/gno howl/did

Suggestion: may be a good idea to use a custom entrypoint script that can parse $1 values like bash / sh and execute the commands accordingly, useful when debugging the container itself. Personally I just switched back and forth from ENTRYPOINT to CMD so I could test it out doing did bash.

@thehowl thehowl changed the title fix dockerfile path, add git to container fix dockerfile executable path, add git to container Jan 29, 2024
examples/dockerfile Outdated Show resolved Hide resolved
@lukaszachy
Copy link
Collaborator

Suggestion: may be a good idea to use a custom entrypoint script that can parse $1 values like bash / sh and execute the commands accordingly, useful when debugging the container itself. Personally I just switched back and forth from ENTRYPOINT to CMD so I could test it out doing did bash

Isn't using podman run --entrypoint enough?

@thehowl
Copy link
Contributor Author

thehowl commented Feb 1, 2024

Isn't using podman run --entrypoint enough?

Fair point, didn't know the flag

@lukaszachy lukaszachy added this to the 0.22 milestone Feb 9, 2024
@psss psss changed the title fix dockerfile executable path, add git to container Fix dockerfile executable path, add git to container Oct 4, 2024
Copy link
Owner

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this!

@psss psss self-assigned this Oct 4, 2024
@psss psss force-pushed the dev/morgan/fix-dockerfile branch from 14eed4d to 0d0db46 Compare October 4, 2024 15:45
@psss psss added the containers label Oct 4, 2024
@psss psss merged commit bb23ea5 into psss:main Oct 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants