fix compiler warning (openhab#17085)

Signed-off-by: Michael Lobstein <[email protected]>
psmedley · Jul 17, 2024 · 3a5bee0 · 3a5bee0
1 parent b123863
commit 3a5bee0
Showing 1 changed file with 3 additions and 7 deletions.
diff --git a/...c/main/java/org/openhab/binding/monopriceaudio/internal/communication/AmplifierModel.java b/...c/main/java/org/openhab/binding/monopriceaudio/internal/communication/AmplifierModel.java
@@ -270,20 +270,16 @@ private static MonopriceAudioZoneDTO getMonopriceZoneData(String newZoneData) {
 
     public String getZoneIdFromZoneName(String zoneName) {
         for (String zoneId : zoneIdMap.keySet()) {
-            if (zoneIdMap.get(zoneId).equals(zoneName)) {
+            if (zoneName.equals(zoneIdMap.get(zoneId))) {
                 return zoneId;
             }
         }
         return "";
     }
 
     public String getZoneName(String zoneId) {
-        String zoneName = zoneIdMap.get(zoneId);
-        if (zoneName != null) {
-            return zoneName;
-        } else {
-            return "";
-        }
+        final String zoneName = zoneIdMap.get(zoneId);
+        return zoneName != null ? zoneName : "";
     }
 
     public String getCmdPrefix() {