habe noch einen fehler gefunden :-( #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyever, we should use a static/protected _createOn
|
Sieht gut aus, aber es gibt noch einige Konflikten. (also my German sucks) |
|
is it on me to change sth? (not that familiar with a collaborating git as u know :-)) |
|
Yes. The quickest way would be to take the clean version of my repo and apply the fix by hand again. Or rebase. |
|
I've rebased and merged this PR here ef23cea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Die Range.createOn-Methode gibt es anscheinend jetzt auch nur noch als static/protected mit Unterstrich (aber dann funktionierts auch wieder). Danke für's einspielen, wenn geprüft.