Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEATURE: improve styling of empty ContentCollection overlay #57

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

FEATURE: improve styling of empty ContentCollection overlay #57

wants to merge 2 commits into from

Conversation

zaveryukha
Copy link
Member

No description provided.

@zaveryukha zaveryukha requested a review from dimaip March 29, 2019 15:11
dimaip
dimaip requested changes Apr 1, 2019
View reviewed changes
Copy link
Member

@dimaip dimaip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All is cool, but the filename is rather strange: _ux_new... Any better ideas?

@dimaip dimaip changed the title TASK: add custom UX css for new items FEATURE: add custom UX css for new items Apr 1, 2019
@dimaip dimaip changed the title FEATURE: add custom UX css for new items FEATURE: improve styling of empty ContentCollection overlay Apr 1, 2019
dimaip
dimaip requested changes May 3, 2019
View reviewed changes
Copy link
Member

@dimaip dimaip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not there yet ;)
What about _neosContentCollectionOverlay?
Naming things well is super important!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaip dimaip dimaip requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaveryukha @dimaip