Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins fix/logs #403

Merged
merged 2 commits into from
Oct 31, 2020
Merged

plugins fix/logs #403

merged 2 commits into from
Oct 31, 2020

Conversation

zomfg
Copy link

@zomfg zomfg commented Oct 28, 2020

This should fix #396 (works for me™)
while I was there:

  • some small improvements to the parsing of the .ini (exec args parsing could be better though, but can be worked around)
  • added a documented template for the said .ini
  • added plugin output (and some other info) to the logs

@psieg
Copy link
Owner

psieg commented Oct 31, 2020

Which part is it that broke with .22? I remember any changes to plugins...

@zomfg
Copy link
Author

zomfg commented Oct 31, 2020

passing "foo -bar -baz" as is to QProcess does not seem to work (any more?)
splitting it into "foo" program and ("-bar", "-baz") args works
maybe Qt quietly cleaned this misuse a while back (setArguments is there since 5.1), not sure

@psieg
Copy link
Owner

psieg commented Oct 31, 2020

I see. Thanks for the details

@psieg psieg merged commit 493c763 into psieg:master Oct 31, 2020
@zomfg zomfg deleted the feature/plugin-verbosity branch October 31, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin not running on version higher than 5.11.2.21 on Windows
2 participants