Skip to content

Commit

Permalink
Fix how signals are disconnected in LedDeviceManager (#331)
Browse files Browse the repository at this point in the history
This was introduced in b464611. Instead of disconnecting this=>m_ledDevice, it disconnects this=>*, breaking recovery logic
  • Loading branch information
psieg committed Sep 5, 2021
1 parent c66f962 commit 9151a1a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Software/src/LedDeviceManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -575,8 +575,8 @@ void LedDeviceManager::disconnectSignalSlotsLedDevice()
qWarning() << Q_FUNC_INFO << "m_ledDevice == NULL";
return;
}
m_ledDevice->disconnect(this, nullptr, nullptr, nullptr);
disconnect(m_ledDevice, nullptr, nullptr, nullptr);
disconnect(m_ledDevice, nullptr, this, nullptr);
disconnect(this, nullptr, m_ledDevice, nullptr);
}

void LedDeviceManager::cmdQueueAppend(LedDeviceCommands::Cmd cmd)
Expand Down

0 comments on commit 9151a1a

Please sign in to comment.