Allow charset normalizer >=2 and <4 #6261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
requested changes
Oct 20, 2022
deedy5
changed the title
|
Yes, and given this isn't critical path for most users it's not critical to force people through a major version change to get that. If they use character detection of any sort and need performance they can force it to upgrade, but that's not our job |
sigmavirus24
approved these changes
Oct 20, 2022
sethmlarson
approved these changes
Oct 20, 2022
nateprewitt
approved these changes
Oct 20, 2022
|
Thanks @deedy5! |
|
Any estimation on a new release with this fix? |
hswong3i
added a commit
to alvistack/psf-requests
that referenced
this pull request
Oct 27, 2022
git clean -xdf
tar zcvf ../python-requests_2.28.1.orig.tar.gz --exclude=.git .
debuild -uc -us
cp python-requests.spec ../python-requests_2.28.1-1.spec
mv ../python*-requests*2.28.1*.{gz,xz,spec,dsc} /osc/home\:alvistack/psf-requests-2.28.1
rm -rf ../python*-requests_2.28.1*.*
See psf#6261
Signed-off-by: Wong Hoi Sing Edison <[email protected]>
This was referenced Dec 5, 2022
Closed
This was referenced Dec 30, 2022
Merged
|
This should now be available on PyPI in Requests 2.28.2. |
12 tasks
chosak
added a commit
to cfpb/consumerfinance.gov
that referenced
this pull request
Apr 19, 2023
We currently pin requests to version 2.27.1. This was last bumped in May of 2022 in 24808f0. Over time its version has been incremented a few times. Currently if you run tox you see an error like this: > /home/runner/work/consumerfinance.gov/consumerfinance.gov/.tox/unittest/lib/python3.8/site-packages/requests/__init__.py:102: RequestsDependencyWarning: urllib3 (1.26.15) or chardet (5.1.0)/charset_normalizer (2.0.12) doesn't match a supported version! For example, a recent GHA run: https://github.com/cfpb/consumerfinance.gov/actions/runs/4737203702/jobs/8409716743 I'm not entirely sure why this started showing up now, but it seems to have to do with psf/requests#6261. Removing our requests pin seems to work fine.
3 tasks
matthewarmand
pushed a commit
to matthewarmand/requests
that referenced
this pull request
May 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charset-normalizer 3.0.0 has been released.