Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable pytest messing with warnings. #4056

Merged
merged 2 commits into from
May 24, 2017
Merged

Conversation

Lukasa
Copy link
Member

@Lukasa Lukasa commented May 24, 2017

We may be able to remove this if pytest resolves pytest-dev/pytest#2430, but until that point we need to turn the old behaviour back on.

We may be able to remove this if pytest resolves pytest-dev/pytest#2430
Copy link
Member

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good when builds finish.

@Lukasa
Copy link
Member Author

Lukasa commented May 24, 2017

I want to point out that it's pretty stupid that we have to do this, but there we are.

@codecov-io
Copy link

codecov-io commented May 24, 2017

Codecov Report

Merging #4056 into master will increase coverage by 3.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4056      +/-   ##
==========================================
+ Coverage   86.66%   89.75%   +3.08%     
==========================================
  Files          15       15              
  Lines        1942     1942              
==========================================
+ Hits         1683     1743      +60     
+ Misses        259      199      -60
Impacted Files Coverage Δ
requests/adapters.py 92.92% <0%> (+0.47%) ⬆️
requests/sessions.py 93.95% <0%> (+1.42%) ⬆️
requests/models.py 93.42% <0%> (+2.26%) ⬆️
requests/_internal_utils.py 100% <0%> (+6.25%) ⬆️
requests/utils.py 86.25% <0%> (+7%) ⬆️
...es/urllib3/packages/ssl_match_hostname/__init__.py 93.54% <0%> (+9.67%) ⬆️
requests/packages/chardet/compat.py 100% <0%> (+35.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb67a1...f3d310b. Read the comment docs.

@Lukasa Lukasa merged commit 0371081 into psf:master May 24, 2017
@Lukasa Lukasa deleted the pytest-httpbin-fix branch May 24, 2017 17:46
@nicoddemus
Copy link
Contributor

I want to point out that it's pretty stupid that we have to do this, but there we are.

Hi @Lukasa, sorry to hear that this affected you guys so. We are having some discussion related to this on pytest-dev/pytest#2430, it mean a lot if you could join the discussion and share your thoughts. 👍

@Lukasa
Copy link
Member Author

Lukasa commented May 25, 2017

@niccoddemus Yeah, I saw that thread. I am not sure how much value I can provide by weighing in: your warnings filter as added prevented us from tweaking the filter ourselves for testing purposes. I can drop in though.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning integration breaks warnings.filterwarnings
5 participants