-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable pytest messing with warnings. #4056
Conversation
We may be able to remove this if pytest resolves pytest-dev/pytest#2430
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good when builds finish.
I want to point out that it's pretty stupid that we have to do this, but there we are. |
Codecov Report
@@ Coverage Diff @@
## master #4056 +/- ##
==========================================
+ Coverage 86.66% 89.75% +3.08%
==========================================
Files 15 15
Lines 1942 1942
==========================================
+ Hits 1683 1743 +60
+ Misses 259 199 -60
Continue to review full report at Codecov.
|
Hi @Lukasa, sorry to hear that this affected you guys so. We are having some discussion related to this on pytest-dev/pytest#2430, it mean a lot if you could join the discussion and share your thoughts. 👍 |
@niccoddemus Yeah, I saw that thread. I am not sure how much value I can provide by weighing in: your warnings filter as added prevented us from tweaking the filter ourselves for testing purposes. I can drop in though. |
We may be able to remove this if pytest resolves pytest-dev/pytest#2430, but until that point we need to turn the old behaviour back on.