Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decoding fix for Streaming Requests docs #3678

Merged
merged 2 commits into from
Nov 14, 2016

Conversation

nateprewitt
Copy link
Member

This will address #3675 with 71b8941. I've added an additional commit (d81ad06) noting a suggested best practice of providing an encoding fallback when using the decode_unicode parameter. This is an optional improvement that I can strip if we only want the bare bones fix.

@Lukasa
Copy link
Member

Lukasa commented Nov 14, 2016

LGTM, let's do this! Thanks @nateprewitt! ✨ 🍰 ✨

@Lukasa Lukasa merged commit 33bd38b into psf:master Nov 14, 2016
@nateprewitt nateprewitt deleted the 3675_streaming_docs branch November 14, 2016 16:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants