Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor operations to fully work on AArch64. #191

Merged
merged 3 commits into from
May 26, 2024
Merged

Conversation

diegorusso
Copy link
Contributor

@diegorusso diegorusso commented May 23, 2024

Create IntelPstateOperation class for Intel P-State operations.
Enable CPUGovernor on AArch64 platforms.
Replace all Class names with super() in the init method.

Create IntelPstateOperation class for Intel P-State operations.
Enable CPUGovernor on AArch64 platforms.
@diegorusso
Copy link
Contributor Author

cc @vstinner @corona10 @mdboom

@corona10 corona10 self-assigned this May 23, 2024
@corona10
Copy link
Member

I will take a look by this weekend :)

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to avoid moving code? It makes the diff harder to review.

Like leaving TurboBoostIntelPstate after TurboBoostMSR.

pyperf/_system.py Outdated Show resolved Hide resolved
pyperf/_system.py Outdated Show resolved Hide resolved
pyperf/_system.py Outdated Show resolved Hide resolved
@diegorusso
Copy link
Contributor Author

Can you try to avoid moving code? It makes the diff harder to review.

Like leaving TurboBoostIntelPstate after TurboBoostMSR.

Done, I tried moving less code possible.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall change LGTM. I let @corona10 do a second review.

pyperf/_system.py Outdated Show resolved Hide resolved
pyperf/_system.py Show resolved Hide resolved
Co-authored-by: Victor Stinner <[email protected]>
@corona10 corona10 merged commit 2b9591d into psf:main May 26, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants