-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor operations to fully work on AArch64. #191
Conversation
Create IntelPstateOperation class for Intel P-State operations. Enable CPUGovernor on AArch64 platforms.
I will take a look by this weekend :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to avoid moving code? It makes the diff harder to review.
Like leaving TurboBoostIntelPstate after TurboBoostMSR.
Done, I tried moving less code possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The overall change LGTM. I let @corona10 do a second review.
Co-authored-by: Victor Stinner <[email protected]>
Create IntelPstateOperation class for Intel P-State operations.
Enable CPUGovernor on AArch64 platforms.
Replace all Class names with super() in the init method.