Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic in MSR availability test #186

Merged
merged 1 commit into from
May 3, 2024
Merged

Fix logic in MSR availability test #186

merged 1 commit into from
May 3, 2024

Conversation

mdboom
Copy link
Collaborator

@mdboom mdboom commented May 3, 2024

As @vstinner pointed out the logic to turn off MSR setting on non-Intel hardware was reversed.

@mdboom mdboom requested a review from vstinner May 3, 2024 13:49
vstinner
vstinner approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner vstinner merged commit 555a168 into psf:main May 3, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdboom @vstinner