Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mem_max_rss measurement on macOS #173

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

mdboom
Copy link
Collaborator

@mdboom mdboom commented Mar 1, 2024

On BSD/darwin, ru_maxrss is defined in "bytes", unlike Linux where it is "kilobytes". Therefore, this code was wrongly multiplying the result by 1024. Rather than just fixing it here, it seems better to reuse the already correct get_max_rss function (used for calculating command_max_rss) elsewhere.

On BSD/darwin, ru_maxrss is defined in "bytes", unlike Linux
where it is "kilobytes".  Therefore, this code was wrongly
multiplying the result by 1024.  Rather than just fixing it
here, it seems better to reuse the already correct `get_max_rss`
function (used for calculating `command_max_rss`) elsewhere.
@mdboom mdboom requested a review from corona10 March 1, 2024 13:54
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice catch :)

@corona10 corona10 merged commit c960443 into psf:main Mar 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants