Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support loop_factory parameter in bench_async_func #157

Merged
merged 2 commits into from
Mar 23, 2023
Merged

Support loop_factory parameter in bench_async_func #157

merged 2 commits into from
Mar 23, 2023

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented Mar 15, 2023

Fixes GH-156

@itamaro itamaro mentioned this pull request Mar 20, 2023
Merged
corona10
corona10 reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to update the
https://github.com/psf/pyperf/blob/main/doc/changelog.rst
for this change as 2.6.0?

corona10
corona10 approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit 989d38f into psf:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

@corona10 corona10 corona10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support custom loop factory in bench_async_func
3 participants
@itamaro @methane @corona10