-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop support of Python older than 3.7 #312
Conversation
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
we have to make such change in a 0.14.0 release |
That's fine by me -- IMO we technically can make it with a patch as well since we're pre-1.0, but I don't have any preference and doing it with |
python 3.7 goes eol at the end of the month - it would not be unreasonable to drop support for that too in the next release |
One of CacheControl's major users is The current |
Of course whether you want to continue to support python 3.7 is up to maintainers here: I just wanted to check that you weren't about to drop python 3.6 and then a week later go "oops, we really ought to have dropped python 3.7 at the same time". FWIW it seems to me that pip's policies are pip's problem! but if you all don't find it burdensome to go along with them then all power to you. |
Agreed 🙂 -- I see it as a balance between courtesy for a downstream and our own development experience. The jump from 3.6 to 3.7 is pretty big in terms of |
Agree, we won't drop Python 3.7 shortly. |
Signed-off-by: Frost Ming [email protected]