Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise exception on invalid toml configuration #4165

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Raise exception on invalid toml configuration #4165

merged 11 commits into from
Jan 26, 2024

Conversation

dankrzeminski32
Copy link
Contributor

@dankrzeminski32 dankrzeminski32 commented Jan 23, 2024 •
edited
Loading

Description

Resolves #4140, raises an exception when toml config file contains a key that doesn't exist in the set of possible cli arguments.

Checklist

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

JelleZijlstra
JelleZijlstra reviewed Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is probably OK but I left a comment on the issue.

src/black/__init__.py Outdated Show resolved Hide resolved
JelleZijlstra
JelleZijlstra approved these changes Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. I pushed a slight wording change.

@JelleZijlstra JelleZijlstra merged commit bccec8a into psf:main Jan 26, 2024
45 of 46 checks passed
@dankrzeminski32
Copy link
Contributor Author

Great, thanks for the help.

@hauntsaninja
Copy link
Collaborator

Thank you for adding this feature!

cobaltt7 pushed a commit to cobaltt7/black that referenced this pull request Jan 26, 2024
@dankrzeminski32 @JelleZijlstra @cobaltt7
Show warning on invalid toml configuration (psf#4165)
0dc25b3 
Co-authored-by: Jelle Zijlstra <[email protected]>
@sigmavirus24 sigmavirus24 mentioned this pull request Feb 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on invalid configuration
3 participants
@dankrzeminski32 @hauntsaninja @JelleZijlstra