-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better error message for invalid exclude types #3764
Conversation
CHANGES.md
Outdated
@@ -32,6 +32,8 @@ | |||
- `.pytest_cache`, `.ruff_cache` and `.vscode` are now excluded by default (#3691) | |||
- Fix black not honouring `pyproject.toml` settings when running `--stdin-filename` and | |||
the `pyproject.toml` found isn't in the current working directory (#3719) | |||
- Black will now error if `exclude` and `extend-exclude` have invalid data types in | |||
`pyproject.toml`, instead of silently doing the wrong thing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`pyproject.toml`, instead of silently doing the wrong thing. | |
`pyproject.toml`, instead of silently doing the wrong thing. (#3764) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github is doing something really weird where the pushes show on the branch in my fork, but don't get reflected in the PR hauntsaninja@9f55e73
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah seems like there is something weird going on. In any case, this PR looks good once GitHub cooperates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For whatever reason, the force in force push seems to wake it up. So I just need to commit an empty commit, push it, delete the commit and force push.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a great workflow
diff-shades reports zero changes comparing this PR (9f55e73) to main (8e618f3).%0A%0A---%0A%0AWhat is this? | Workflow run | diff-shades documentation |
Currently if this is a list, this ends up using the repr of the list as a regex.
Fixes #3574, fixes #3754