Support files with type comment syntax errors #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Mar 6, 2023
|
@ichard26 can you help with re-triggering the workflows? |
|
@ichard26 do you still want to look at this or can I merge it? |
ichard26
approved these changes
Mar 19, 2023
There was a problem hiding this comment.
I wanted to take a look because this PR falls back to using the built-in ast module even on Python 3.7 which we avoided doing previously, but that's a really minor edge case — so it's fine. All it might do is make some files with invalid type comments still unparsable.
|
Thanks for the PR @tusharsadhwani! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3593
Checklist - did you ...
CHANGES.mdif necessary?