Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an f-string crash in ESP. #3463

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Fix an f-string crash in ESP. #3463

merged 2 commits into from
Dec 20, 2022

Conversation

yilei
Copy link
Contributor

@yilei yilei commented Dec 20, 2022

Description

Fixes #3459.

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

JelleZijlstra
JelleZijlstra approved these changes Dec 20, 2022
View reviewed changes
Copy link
Collaborator

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

CHANGES.md Outdated Show resolved Hide resolved
@github-actions
Copy link

diff-shades reports zero changes comparing this PR (782c82b) to main (9ce7572).

What is this? | Workflow run | diff-shades documentation

@JelleZijlstra JelleZijlstra merged commit 1e8217f into psf:main Dec 20, 2022
@yilei yilei deleted the fstring branch December 20, 2022 17:28
@zanieb zanieb mentioned this pull request Jan 13, 2023
Closed
hugovk pushed a commit to hugovk/black that referenced this pull request Jan 16, 2023
@yilei @hugovk
Fix an f-string crash in ESP. (psf#3463)
84be11b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Black --preview (ESP) crashes on an implicitly concatenated f-string
2 participants
@yilei @JelleZijlstra