Fix a crash when a colon line is marked between # fmt: off and # fmt: on
#3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ichard26
approved these changes
Dec 14, 2022
There was a problem hiding this comment.
I feel like we should write developer docs on how fmt: off/on/skip work. The logic is already complicated as-is and the edge cases are incredibly confusing sometimes...
Also technically this is invalid use of # fmt: off/on but this is just a limitation of Black since there's no way to represent a # fmt: on at the right indent level right between indention levels.
|
Oh where are my manners?... Thank you very much for investigating and filing a PR, it's appreciated! 🖤 |
ichard26
added
C: invalid code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3436.
Note that the
# fmt: online is always normalized to the next statement so its indentation is moved in this case. This isn't ideal, but at least it shouldn't crash.Checklist - did you ...
CHANGES.mdif necessary?