Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for named exprs inside function calls as gen-exps #3327

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Add support for named exprs inside function calls as gen-exps #3327

merged 1 commit into from
Oct 10, 2022

Conversation

isidentical
Copy link
Collaborator

@isidentical isidentical commented Oct 10, 2022 •
edited
Loading

Description

Fixes #2551

Checklist - did you ...

  • Add an entry in CHANGES.md if necessary?
  • Add / update tests if necessary?
  • Add new / update outdated documentation?

@isidentical isidentical mentioned this pull request Oct 10, 2022
Closed
@isidentical
Copy link
Collaborator Author

@JelleZijlstra that was one of the fastest PR reviews I've ever seen 😄

@github-actions
Copy link

diff-shades reports zero changes comparing this PR (a29b0c9) to main (b60b85b).

What is this? | Workflow run | diff-shades documentation

@cooperlees
Copy link
Collaborator

Well tested, reviewed by Jelle, lets make it a fast merge too :D

@cooperlees cooperlees merged commit 1c786ee into psf:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error trying to format line with parameter assignment and generator
3 participants
@isidentical @cooperlees @JelleZijlstra