-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create FAQ documentation #2247
Create FAQ documentation #2247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey thanks for writing up a draft real quick! I got quite a bit of feedback so let's get started:
RE: Folder vs single document
I agree a single page FAQ would be better. The good news is that I found a RST directive that almost does what we want. It produces a nice TOC in the style of the TOCTREE but for the current document. Unfortunately the default styling with the current theme is IMO ugly:
Thankfully it's quite easy to fix this with some custom CSS:
.contents.topic {
background: none;
border: none;
}
We can add this CSS to docs/_static/custom.css
which gets picked up by Sphinx.
Here's the markup you'll need to use this directive (yes, I still prefer MyST over RST):
```{contents}
:local:
:backlinks: none
```
OR in reStructuredText:
.. contents::
:local:
:backlinks: none
RE: Top level placement
I was more thinking putting it at the end of the "user guide" section, so after the "Guides" section. It's IMO a bit jarring to have a "Frequently Asked Questions" right after "Usage and Configuration".
Thanks for the review! I didn't actually know about the |
Wait, I forgot about the changelog entry. Honestly I could go either way, I like adding documentation stuff to the changelog as an another way of saying "thanks!" but they're aren't exactly user facing changes. |
I think it's useful to add a changelog as a way of alerting users "here's this new useful page you can look at". |
There ya go! |
It's been two days without any activity (while having two reviews, one of them approving 😉) so I'm just going to merge. Thank you again @felix-hilden! |
Hi, this PR creates a Frequently Asked Questions document for our users to read. Hopefully they actually read it too. Items included are: Black's non-API, AST safety, style stability, file discovery, Flake8 disagreements and Python 2 support. Hopefully I've got the answers down in general.
Anyways, a few points of contention:
skip news
? Also, I'll leave this as a draft so we can discuss a bit.Closes #2176, closes #1946.