add --force-exclude argument

[itajaja]

fixes #438

I Have not added or amended tests yet, but if we agree on the approach, I can work on them

[itajaja]

ping, I think this would help a lot of people :)

[RCM7]

+1 this would definitely help! @ambv Any chance you will find the time to take a look?
Is there anything we can help with?

[yukw777]

+1

@itajaja do you need any help with the lint failure?

[itajaja]

if you want to help, you are welcome to. I am honestly tired of trying to get this merged. black team has been pretty unresponsive about this 🤷

[jimmy927]

I can't understand why this is still pending, without this i basically cant make black work together with pycharm.

[yukw777]

@itajaja here's a PR that fixes the lint issue: itajaja#1 Hopefully this will move things forward.

[itajaja]

@ambv any chance you can have a look at this?

#438 (comment) I am holding you accountable! :P

[yukw777]

Ping! @ambv

[yukw777]

I'm not sure why the travis ci job is failing.. coverage run tests/test_black.py passes on this branch on my laptop.

[JelleZijlstra]

Sorry for the long wait here! I have a few comments.

[JelleZijlstra]

Should say force_exclude, not exclude.

[JelleZijlstra]

I feel like this should also obey the force_exclude_regex. It will be surprising if I force-exclude a file and it gets included anyway because it's in a directory I included.

[JelleZijlstra]

Working on making my own requested changes now

[jimmy927]

I can do QA on this one if needed in a more complex devel-environment no ensure desired workflow can be achieved.

[cooperlees]

I can do QA on this one if needed in a more complex devel-environment no ensure desired workflow can be achieved.

Please sir. With your confidence we'd look to merge this today!

[JelleZijlstra]

@jimmy927 that'd be great! Please let me know if you notice anything amiss.

[jimmy927]

@jimmy927 that'd be great! Please let me know if you notice anything amiss.

Can i just check out the repo and run it as is ?
Or are there any build artefacts that i need ?

[JelleZijlstra]

@jimmy927 yes, you can check out the repo and run black.py, although you may have to install dependencies (maybe with pip install -e . in the Black repo).

[JelleZijlstra]

OK CI is finally green. I ended up making a few more changes:

• Split off a get_sources() function because flake8 thought main got too complex
• Make gitignore matching look at the relative path of the file, so we don't get bitten by the fact that Travis runs CI in a directory called build.

[itajaja]

nice!

[berkowitzi]

@JelleZijlstra are there plans to cut a release with this improvement?

[jimmy927]

@JelleZijlstra are there plans to cut a release with this improvement?

you can do the following in the meantime:

pip install git+git://github.com/psf/black.git

then find your env and run the bin, it should look like this:

(black) ➜  black ./bin/black --version
black, version 19.10b1.dev126+g11f130b

[jimmy927]

@jimmy927 yes, you can check out the repo and run black.py, although you may have to install dependencies (maybe with pip install -e . in the Black repo).

Works great!
Tested with pycharm now!

see config:

[Saksow]

We would be happy to use force-exclude in pyproject.toml using a black release. We are using black with pre-commit and want to consolidate all configs inside pyproject.toml. How do I track this to be released?

[ichard26]

@Saksow if I'm not misremembering, --force-exclude is available in Black version 20.8b1 :)