Black incorrectly preserves trailing comma on one-line collection literals and function declarations

[alatar224]

The trailing comma is unnecessarily preserved when collapsing an inline dict that is a function argument, though not when the dict is in an assignment. Furthermore, a dict with a trailing comma isn't being collapsed when it could fit onto a single line (I'm not familiar enough to know if this part is a real bug, but it seemed weird). See MWE below.

$ python --version
Python 3.6.0
$ black --version
black, version 19.10b0
$ black --code $'run({\n    1: 2,\n})'
run(
    {1: 2,}
)
$ black --code $'a = {\n    1:2,\n}'
a = {
    1: 2,
}
$ black --code $'a = {\n    1:2\n}'
a = {1: 2}

I couldn't find this anywhere else, apologies if this is a duplicate. Possibly related #925 -- at least, the behavior seemed OK then, anyway.

[zsol]

This is a bug unfortunately. There are two acceptable behaviors for black:

1. expand all collection literals with trailing commas, not just top level ones (this would make the first example format to

run(
    {
        1: 2,
    }
)

2. If a collection literal is not expanded, remove the trailing comma. This would make the first example format to

run(
    {1: 2}
)

[SpotlightKid]

As mentioned in #1010, this triggers the E231 flake8 error.

[zsol]

#1288 will address this issue, it's going to get fixed as part of the next (stable) release

[Borda]

You can still get it if you run black with the -C option 🐿️

[hauntsaninja]

That's not true with latest black. Please open a new issue with a repro if you still see something like this with latest black.