Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-generated documentation site with pydoctor. #53

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

tristanlatr
Copy link

@tristanlatr tristanlatr commented Jun 27, 2022

@pschmitt
Copy link
Owner

Can you please rebase on the current master?

@@ -244,7 +244,9 @@ def run_job_by_name(self, name, *args, **kwargs):
return self.run_job(job["id"], *args, **kwargs)

def get_executions_for_job(self, job_id=None, job_name=None, **kwargs):
# http://rundeck.org/docs/api/#getting-executions-for-a-job
"""
`Docs <https://docs.rundeck.com/docs/api/rundeck-api.html#getting-executions-for-a-job>`_
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the backticks necessary?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make a link, yes

- name: Set up Python 3.8
uses: actions/setup-python@v2
with:
python-version: 3.8
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not 3.10?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason, please feel free to change it.

@tristanlatr
Copy link
Author

Hi @pschmitt,

Note that you will have to enable Github pages on the repo for it to be served.

The flake8 rule about 80 characters max might pose issues for docstrings, though. Even if ReStruturedText allows to wrap links on several lines, it will be harder for viewers that reads the source code to go to that link, because IDE environment usually don't support wrapping link in several lines.

Tell me what you think,

@pschmitt
Copy link
Owner

pschmitt commented Jul 5, 2022

Hm. There's gotta be a way to noqa the dostrings

@tristanlatr
Copy link
Author

There is a way: twisted/pydoctor#673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants