feat: remove password and authorization user as required field

psanders · Mar 8, 2024 · 635b59e · 635b59e
1 parent ef2cbd1
commit 635b59e
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 16 deletions.
diff --git a/simplephone/dist/phone.js b/simplephone/dist/phone.js
diff --git a/simplephone/dist/phone.js.map b/simplephone/dist/phone.js.map
diff --git a/simplephone/public/index.html b/simplephone/public/index.html
@@ -22,6 +22,7 @@
 
 <body>
   <h1>SimplePhone</h1>
+
   <table>
     <tr>
       <td>Display Name:</td>

diff --git a/simplephone/public/lib/phone.js b/simplephone/public/lib/phone.js
diff --git a/simplephone/src/phone.ts b/simplephone/src/phone.ts
@@ -103,7 +103,7 @@ class Phone {
         }
       },
       userAgentOptions: {
-        displayName: this.displayNameInput.value,
+        displayName: this.displayNameInput.value || "Anonymous",
         authorizationUsername: this.authorizationUserInput.value || this.usernameInput.value,
         authorizationPassword: this.passwordInput.value,
         allowLegacyNotifications: false,
@@ -167,9 +167,7 @@ class Phone {
 
   hasAllRequiredFields() {
     return (
-      this.displayNameInput.value &&
       this.usernameInput.value &&
-      this.passwordInput.value &&
       this.domainInput.value &&
       this.serverInput.value &&
       this.targetAORInput.value
@@ -194,7 +192,7 @@ class Phone {
 
   saveConfig() {
     if (!this.hasAllRequiredFields()) {
-      window.alert("All fields are required.");
+      window.alert("The following fields are required: Username, Domain, Signal Server, and Target AOR");
       return;
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -22,6 +22,7 @@ @@
     <body>
       <h1>SimplePhone</h1>
       <table>
         <tr>
           <td>Display Name:</td>
@@ Expand Down @@