clang-tidy #5
Open
clang-tidy #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psampathkumar
force-pushed
the
clang-tidy
branch
6 times, most recently
from
4f5bb16 to
4530622
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
client/widgetdecorations.h
Outdated
| @@ -12,6 +12,7 @@ | |||
| ************* V ******************************************************/ | |||
| #pragma once | |||
|
|
|||
| #include <QFlags> | |||
There was a problem hiding this comment.
warning: 'QFlags' file not found [clang-diagnostic-error]
#include <QFlags>
^
psampathkumar
force-pushed
the
clang-tidy
branch
2 times, most recently
from
1985762 to
16af97b
Compare
common/government.h
Outdated
| }; | ||
|
|
||
| extern std::vector<government> governments; |
There was a problem hiding this comment.
warning: variable 'std' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]
extern std::vector<government> governments;
^
psampathkumar
force-pushed
the
clang-tidy
branch
4 times, most recently
from
8ea18ad to
cff033d
Compare
psampathkumar
force-pushed
the
clang-tidy
branch
2 times, most recently
from
ec4e262 to
29f6662
Compare
Workflow for suggesstions using clang-tidy
psampathkumar
force-pushed
the
clang-tidy
branch
from
29f6662 to
66b9e23
Compare
psampathkumar
force-pushed
the
ltex25-nomove
branch
from
8f89cc2 to
da32c65
Compare
psampathkumar
force-pushed
the
ltex25-nomove
branch
from
da32c65 to
70011cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.