Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses Psalm's dev artifacts that are not guaranteed to be installed #60

Closed
weirdan opened this issue Jul 1, 2021 · 0 comments · Fixed by #61
Closed

Uses Psalm's dev artifacts that are not guaranteed to be installed #60

weirdan opened this issue Jul 1, 2021 · 0 comments · Fixed by #61
Labels
bug Something isn't working

Comments

@weirdan
Copy link
Member

weirdan commented Jul 1, 2021

With Composer 2.1 default download method changed to zip/dist (changelog entry, PR), even for dev-* versions. This means .gitattributes of dependencies are no longer ignored, specifically vimeo/psalm:dev-master no longer brings along vendor/vimeo/psalm/tests folder.

This causes issues when dependencies are installed in a freshly built container, as vendor/vimeo/psalm/tests/Internal/Provider/FakeFileProvider.php (required in src/OnlineChecker.php) is not available when installed this way.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use FakeFileProvider from vendor/vimeo/psalm/src weirdan/psalm.dev
1 participant
@weirdan