Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable builds on GH Actions #45

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Enable builds on GH Actions #45

merged 1 commit into from
Jun 29, 2021

Conversation

weirdan
Copy link
Member

@weirdan weirdan commented Jun 29, 2021

No description provided.

@tm1000
Copy link
Collaborator

tm1000 commented Jun 29, 2021

LGTM

@tm1000 tm1000 merged commit 56d0e44 into master Jun 29, 2021
@weirdan weirdan deleted the enable-gh-actions branch June 29, 2021 00:34
@weirdan
Copy link
Member Author

weirdan commented Jun 29, 2021

Oh, I didn't realize there was an active maintainer around, excuse me my previous cavalier merge. Still, there's quite a few outdated dependencies here - are you going to address those, @tm1000, or should I? I'm not at all familiar with vscode extensions, so I would rather prefer someone else did that.

@tm1000
Copy link
Collaborator

tm1000 commented Jun 29, 2021

@weirdan Yes. @muglug made me a maintainer last Friday and I've already been doing some changes. I pushed them as a draft PR in #46. All dependencies are updated in there along with other changes that work around vimeo/psalm#6007 and vimeo/psalm#6012. For 2.x to really go live I need the following merged:

  1. Fixes #6008, Enabled onSave and onOpen textDocument vimeo/psalm#6010
  2. Fixes #6013, implement workspace/didChangeWatchedFiles vimeo/psalm#6014 (Which depends on #6010)

I also want to add the ability to Filter \Psalm\Config::REPORT_INFO through a CLI option (https://github.com/vimeo/psalm/blob/master/src/Psalm/Internal/LanguageServer/LanguageServer.php#L349) so I will be doing a PR for that soon too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants