Patch stubs 1 #81
Merged
Patch stubs 1 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phpunit upstream indents (prefixes) docblock @param annotations and I can imagine that some white-space has been taken over from that into the stub files when writing them. Also for separation by empty lines between methods which looks as well as an error quickly porting from upstream (better than anything else).
File contains two classes (one class and one interface), the mock-object interface was missing resolution for Constraint. This Constraint is PHPUnit\Framework\Constraint\Constraint.
Remove markers that command PHP_CodeSniffer (Pear package base-name for "phpcs") to skip files based on their own configuration as those files are already with the .phpstub extension which effectively has them not configured/already ignored by phpcs base/upstr. configuration (project configuration file: phpcs.xml.dist) Fix is to remove these markers/directives, also not all .phpstub files had them therefore this is effectively streamlining the file formats for .phpstub to this regard.
weirdan
requested changes
Aug 6, 2020
|
Build failures are unrelated (caused by PHP8-compatible |
Previously the create-configured and create-partial mock-methods were not part of the stub. Add them.
|
@weirdan Thanks for the review. Didn't check Phpunit 8.5 otherwise I would have noticed that already, was wondering why it was "missing" and suspected such a change but was not aware of the Phpunit version. Also thanks for the comment on the failing build, I could see that I did not introduce it but didn't understood exactly why it failed (but was suspecting something with Php 8 and the new match). Updated now, please take a look. |
weirdan
approved these changes
Aug 6, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see each message for comment/description.