Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run test suite with PHP 8.3 #355

Merged
merged 3 commits into from
Nov 10, 2023
Merged

Run test suite with PHP 8.3 #355

merged 3 commits into from
Nov 10, 2023

Conversation

Nielsvanpach
Copy link
Contributor

@Nielsvanpach Nielsvanpach commented Nov 6, 2023 •
edited
Loading

Changes

  • Run test suite with 8.3, which is released in 2 weeks
  • Run psalm action with 8.2 instead of 8.1 (8.1 is skipped in tests.yml)
  • Run test when config file has changes

@alies-dev alies-dev self-requested a review November 6, 2023 16:45
alies-dev
alies-dev approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@alies-dev alies-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, @Nielsvanpach, thank you!

.github/workflows/test.yml Show resolved Hide resolved
@alies-dev alies-dev added the release:internal for PRs only (used by release-drafter) label Nov 6, 2023
@alies-dev alies-dev changed the title 🚀 Run test suite with 8.3 Run test suite with PHP 8.3 Nov 6, 2023
@alies-dev alies-dev merged commit 3a35b06 into psalm:master Nov 10, 2023
@alies-dev
Copy link
Collaborator

alies-dev commented Nov 10, 2023 •
edited
Loading

@Nielsvanpach
BTW, there is one failing test, it's not connected to changes you made, so you can ignore it. I'm struggling to fix it for a long time, I will appreciate any help with this. This test (and incorrect types returned by the plugin) blocks the whole release (which should be great and work in some cases better than LaraStan 🚀 )

image

@Nielsvanpach Nielsvanpach deleted the php83 branch November 10, 2023 14:59
@alies-dev
Copy link
Collaborator

it's finally releases https://github.com/psalm/psalm-plugin-laravel/releases/tag/v2.9.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alies-dev alies-dev alies-dev approved these changes

Assignees

@Nielsvanpach Nielsvanpach

Labels
release:internal for PRs only (used by release-drafter)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Nielsvanpach @alies-dev