Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant Collection stub #21

Closed
wants to merge 1 commit into from

Conversation

jaikdean
Copy link
Contributor

Doctrine\Common\Collections\Collection has Psalm annotations as of 1.6.0. One or two of the annotations in the stub were incorrect, and are fixed in doctrine/collections.

@weirdan
Copy link
Member

weirdan commented Jul 20, 2019

Not going to merge this

  1. doctrine/collection currently has wrong type for Collection::key()
  2. People may still use 1.0-1.5

What I'm going to do instead is fix the wrong types for partition (I suppose you were referring to them), do a PR to doctrine/collections correcting the key() type and once that fixed, selectively disable Collection stub when running with doctrine/collections 1.6.X+

@weirdan
Copy link
Member

weirdan commented Jul 20, 2019

key() type was fixed in doctrine/collections@6aab75b (not released yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants